hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhishek Singh Chouhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14427) Fix 'should' assertions in TestFastFail
Date Wed, 21 Oct 2015 07:33:28 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966364#comment-14966364

Abhishek Singh Chouhan commented on HBASE-14427:

I saw the assertions failing on my local setup flakely. All the failures were when all the
gets were successful and there were no PFFEs. This was because in some cases(when the test
failed) upon killing the region server, failover happened fast such that the gets could be
served by the new region server in which case the client threads din't get any exceptions
 . Changed the test such that the mini cluster only has a single RS which when goes down the
clients surely fail and get the PFFEs. Test passes reliably for me on my local setup (no failures
in over 50 iterations).

> Fix 'should' assertions in TestFastFail
> ---------------------------------------
>                 Key: HBASE-14427
>                 URL: https://issues.apache.org/jira/browse/HBASE-14427
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: stack
>            Priority: Minor
>              Labels: beginner
> Over in HBASE-14421, TestFastFail has been failing assertions that talk of events that
'should' be happening. Fix. For now HBASE-14421 has disabled the 'should' assertions. They
seem fine on apache jenkins build but fail fairly reliably for me on alternate HW.
> To address, get familiar with the test. Change the commented out asserts to be yes/no
instead of a 'likely' (On a cursory scan, it is possible that a test run may not involve preemption
and it is these runs that are throwing asserts).

This message was sent by Atlassian JIRA

View raw message