hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14398) Create the fake keys required in the scan path to avoid copy to byte[]
Date Wed, 07 Oct 2015 17:06:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947221#comment-14947221

stack commented on HBASE-14398:

Thanks Anoop.

So, BBC will behind the scenes  just copy from offheap to onheap if you use the array methods
from Cell. I remember us agreeing that this is how this should work.

So, Cells 'length' methods -- getXXXLength -- works for BBC and for Cell.

The discussion here is about the offset argument. The getXXXOffset will return one value if
backed by an array and another if by an offheap BB.

I reread the BBC class comment. It is good on how the Interface should be used. Let me add
a patch  with some more given the discussion above so you don't have to re-explain it all
to me again (you and Ram).

So, now, what to call the 'offset' method when a BBC? getXXXPosition?  The BB doc talks about
position (though it returns it in a method called arrayOffset).?

bq. Can this be getXXXBufferOffset()?

Other methods in BBC talk of ByteBuffer. The above shortens it to Buffer only.

Let me make a patch that folds this helpful feedback from you fellows into javadoc on BBC.

> Create the fake keys required in the scan path to avoid copy to byte[]
> ----------------------------------------------------------------------
>                 Key: HBASE-14398
>                 URL: https://issues.apache.org/jira/browse/HBASE-14398
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>         Attachments: HBASE-14398.patch, HBASE-14398_1.patch
> Already we have created some fake keys for the ByteBufferedCells so that we can avoid
the copy requried to create fake keys. This JIRA aims to fill up all such places so that the
Offheap BBs are not copied to onheap byte[].

This message was sent by Atlassian JIRA

View raw message