hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14257) Periodic flusher only handles hbase:meta, not other system tables
Date Tue, 27 Oct 2015 10:23:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976165#comment-14976165
] 

Hudson commented on HBASE-14257:
--------------------------------

SUCCESS: Integrated in HBase-1.2-IT #245 (See [https://builds.apache.org/job/HBase-1.2-IT/245/])
HBASE-14257 Periodic flusher only handles hbase:meta, not other system (anoopsamjohn: rev
5bf10d122a815e77a84c5639394e5ad2a8e206f1)
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Periodic flusher only handles hbase:meta, not other system tables
> -----------------------------------------------------------------
>
>                 Key: HBASE-14257
>                 URL: https://issues.apache.org/jira/browse/HBASE-14257
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0, 1.2.0
>            Reporter: Lars George
>            Assignee: Abhishek Singh Chouhan
>              Labels: beginner
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-14257.patch, HBASE-14257.patch
>
>
> In {{HRegion.shouldFlush}} we have
> {code}
>     long modifiedFlushCheckInterval = flushCheckInterval;
>     if (getRegionInfo().isMetaRegion() &&
>         getRegionInfo().getReplicaId() == HRegionInfo.DEFAULT_REPLICA_ID) {
>       modifiedFlushCheckInterval = META_CACHE_FLUSH_INTERVAL;
>     }
> {code}
> That method is called by the {{PeriodicMemstoreFlusher}} thread, and prefers the {{hbase:meta}}
only for faster flushing. It should be doing the same for other system tables. I suggest to
use {{HRI.isSystemTable()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message