hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14117) Check DBEs where fields are being read from Bytebuffers but unused.
Date Wed, 07 Oct 2015 03:19:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946174#comment-14946174
] 

Anoop Sam John commented on HBASE-14117:
----------------------------------------

Not able to move it out as subtask and make a top level issue. May be will close it and open
another improvement issue?

> Check DBEs where fields are being read from Bytebuffers but unused.
> -------------------------------------------------------------------
>
>                 Key: HBASE-14117
>                 URL: https://issues.apache.org/jira/browse/HBASE-14117
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Jingcheng Du
>
> {code}
> public Cell getFirstKeyCellInBlock(ByteBuff block) {
>     block.mark();
>     block.position(Bytes.SIZEOF_INT);
>     int keyLength = ByteBuff.readCompressedInt(block);
>     // TODO : See if we can avoid these reads as the read values are not getting used
>     ByteBuff.readCompressedInt(block);
> {code}
> In DBEs many a places we read the integers just to skip them. This JIRA is to see if
we can avoid this and rather go position based, as per a review comment in HBASE-12213.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message