hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed
Date Tue, 27 Oct 2015 03:45:28 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975651#comment-14975651
] 

Hudson commented on HBASE-13318:
--------------------------------

SUCCESS: Integrated in HBase-1.2-IT #244 (See [https://builds.apache.org/job/HBase-1.2-IT/244/])
HBASE-13318 RpcServer.getListenerAddress should handle when the accept (apurtell: rev c706d42e9e260bfb789bd4ada3ab5c2f5bfa0ead)
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenInitializing.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestAsyncIPC.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcHandlerException.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java


> RpcServer.getListenerAddress should handle when the accept channel is closed
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-13318
>                 URL: https://issues.apache.org/jira/browse/HBASE-13318
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Andrew Purtell
>            Priority: Minor
>              Labels: thread-safety
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
>         Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" java.lang.NullPointerException
> 	at org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
> 	at org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
> 	at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
> 	at org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
> 	at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
> 	at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized (acceptChannel is set
to null upon exiting the thread under in a synchronized block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message