hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12769) Replication fails to delete all corresponding zk nodes when peer is removed
Date Fri, 02 Oct 2015 00:49:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940652#comment-14940652
] 

Hadoop QA commented on HBASE-12769:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12764689/12769-v3.txt
  against master branch at commit 2e8575bb0ff84c2c3dbefd166213124abe86cdd1.
  ATTACHMENT ID: 12764689

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +          doFsck(conf, false, true, false, false, false, false, false, false, false,
false, false, null),
+      boolean fixEmptyMetaRegionInfo, boolean fixTableLocks, Boolean fixReplication, TableName
table)

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence

     {color:red}-1 core zombie tests{color}.  There are 9 zombie test(s): 	at org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL.testLabelsTableOpsWithDifferentUsers(TestVisibilityLabelsWithACL.java:262)
	at org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.testNotCachingDataBlocksDuringCompactionInternals(TestCacheOnWrite.java:469)
	at org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.testNotCachingDataBlocksDuringCompaction(TestCacheOnWrite.java:494)
	at org.apache.hadoop.hbase.io.encoding.TestChangingEncoding.testChangingEncoding(TestChangingEncoding.java:201)
	at org.apache.hadoop.hbase.client.TestReplicasClient.testScanWithReplicas(TestReplicasClient.java:599)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFailure(TestExportSnapshot.java:315)
	at org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders.testSeekingOnSample(TestDataBlockEncoders.java:204)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFailure(TestExportSnapshot.java:315)
	at org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence.testOfflineSnapshotDeleteIndependent(TestSnapshotCloneIndependence.java:179)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15853//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15853//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15853//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15853//console

This message is automatically generated.

> Replication fails to delete all corresponding zk nodes when peer is removed
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-12769
>                 URL: https://issues.apache.org/jira/browse/HBASE-12769
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>    Affects Versions: 0.99.2
>            Reporter: Jianwei Cui
>            Priority: Minor
>         Attachments: 12769-v2.txt, 12769-v3.txt, HBASE-12769-trunk-v0.patch, HBASE-12769-trunk-v1.patch
>
>
> When removing a peer, the client side will delete peerId under peersZNode node; then
alive region servers will be notified and delete corresponding hlog queues under its rsZNode
of replication. However, if there are failed servers whose hlog queues have not been transferred
by alive servers(this likely happens if setting a big value to "replication.sleep.before.failover"
and lots of region servers restarted), these hlog queues won't be deleted after the peer is
removed. I think remove_peer should guarantee all corresponding zk nodes have been removed
after it completes; otherwise, if we create a new peer with the same peerId with the removed
one, there might be unexpected data to be replicated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message