hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11590) use a specific ThreadPoolExecutor
Date Fri, 09 Oct 2015 23:00:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951353#comment-14951353
] 

stack commented on HBASE-11590:
-------------------------------

bq. It is however incredible to see how faster/better it is compared to the other pools.

It is in a different place altogether compared to the other two... in terms of timing and
threads used (maybe just because it is more parsimonious in its thread use)? Man.

Thats a very nice compare there [~nkeywal] Sure on the FJP. Thats a substantial enough change
in perf. to make the change.

> use a specific ThreadPoolExecutor
> ---------------------------------
>
>                 Key: HBASE-11590
>                 URL: https://issues.apache.org/jira/browse/HBASE-11590
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, Performance
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: ExecutorServiceTest.java, LifoThreadPoolExecutorSQP.java, UnitQueueP.java,
UnitQueuePU.java, tp.patch
>
>
> The JDK TPE creates all the threads in the pool. As a consequence, we create (by default)
256 threads even if we just need a few.
> The attached TPE create threads only if we have something in the queue.
> On a PE test with replica on, it improved the 99 latency percentile by 5%. 
> Warning: there are likely some race conditions, but I'm posting it here because there
is may be an implementation available somewhere we can use, or a good reason not to do that.
So feedback welcome as usual. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message