Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D329E18D2D for ; Fri, 25 Sep 2015 13:54:09 +0000 (UTC) Received: (qmail 28942 invoked by uid 500); 25 Sep 2015 13:54:04 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 28896 invoked by uid 500); 25 Sep 2015 13:54:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 28881 invoked by uid 99); 25 Sep 2015 13:54:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Sep 2015 13:54:04 +0000 Date: Fri, 25 Sep 2015 13:54:04 +0000 (UTC) From: "Zephyr Guo (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-14490) [RpcServer] reuse buffer and more stricter code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zephyr Guo updated HBASE-14490: ------------------------------- Affects Version/s: 2.0.0 1.1.2 > [RpcServer] reuse buffer and more stricter code > ----------------------------------------------- > > Key: HBASE-14490 > URL: https://issues.apache.org/jira/browse/HBASE-14490 > Project: HBase > Issue Type: Improvement > Components: IPC/RPC > Affects Versions: 2.0.0 > Reporter: Zephyr Guo > Assignee: Zephyr Guo > Attachments: HBASE-14490-v1.patch, Test.java > > > 1.Reuse buffer to read request. > It's not necessary free data's buffer for each request.It can cause memory fragmentation. > 2.There are hidden trouble in socket IO with non-blocking mode. > We just use *channel.read(byteBuffer)* to read data of request(byteBuffer.limit=dataLength).We need *dataLength* bytes but read maybe not fill the *byteBuffer*. > The link is the *read(byteBuffer)* method describe:http://docs.oracle.com/javase/7/docs/api/java/nio/channels/SocketChannel.html#read(java.nio.ByteBuffer) > I write a sample to test it(Test.java). > 3.*channelIO()* method return value > More stricter return value. > So I rewrite *channelIO*.It can work well with non-blocking and back small IO(size