Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C75917EF9 for ; Sat, 19 Sep 2015 00:48:05 +0000 (UTC) Received: (qmail 22747 invoked by uid 500); 19 Sep 2015 00:48:05 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 22630 invoked by uid 500); 19 Sep 2015 00:48:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 22358 invoked by uid 99); 19 Sep 2015 00:48:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Sep 2015 00:48:05 +0000 Date: Sat, 19 Sep 2015 00:48:05 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14449) Rewrite deadlock prevention for concurrent connection close MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876754#comment-14876754 ] Hudson commented on HBASE-14449: -------------------------------- FAILURE: Integrated in HBase-TRUNK #6820 (See [https://builds.apache.org/job/HBase-TRUNK/6820/]) HBASE-14449 Rewrite deadlock prevention for concurrent connection close (tedyu: rev b0f52332651ecbb8af11557df5af3189c7283212) * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java > Rewrite deadlock prevention for concurrent connection close > ----------------------------------------------------------- > > Key: HBASE-14449 > URL: https://issues.apache.org/jira/browse/HBASE-14449 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: 14449-branch-1.0.txt, 14449-v1.txt > > > The deadlock prevention approach used in HBASE-14241 introduces unnecessary logic which is not intuitive. > Depending on the value for config hbase.ipc.client.specificThreadForWriting , there may or may not be CallSender threads running. > The attached patch simplifies deadlock prevention by using a Set which represents the Connections to be closed. Outside the synchronized (connections) block, this Set is iterated where the Connections are closed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)