Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AFD14180C3 for ; Sun, 20 Sep 2015 11:29:04 +0000 (UTC) Received: (qmail 12456 invoked by uid 500); 20 Sep 2015 11:29:04 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 12413 invoked by uid 500); 20 Sep 2015 11:29:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 12402 invoked by uid 99); 20 Sep 2015 11:29:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 20 Sep 2015 11:29:04 +0000 Date: Sun, 20 Sep 2015 11:29:04 +0000 (UTC) From: "Yu Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-14448) Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize wal group name MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-14448: -------------------------- Description: Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which makes the logic ambiguous since a "provider" itself should provide logs. Suggest to directly instantiate FSHlog in RegionGroupingProvider. W.r.t wal group name, now in RegionGroupingProvider it's using sth like "\-null\-" which is quite long and unnecessary. Suggest to directly use ".". For more details, please refer to the initial patch. was: Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which makes the logic ambiguous since a "provider" itself should provide logs. Suggest to directly instantiate FSHlog in RegionGroupingProvider. W.r.t wal group name, now in RegionGroupingProvider it's using sth like "-null-" which is quite long and unnecessary. Suggest to directly use ".". For more details, please refer to the initial patch. > Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize wal group name > ------------------------------------------------------------------------------------------- > > Key: HBASE-14448 > URL: https://issues.apache.org/jira/browse/HBASE-14448 > Project: HBase > Issue Type: Improvement > Reporter: Yu Li > Assignee: Yu Li > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14448.patch, HBASE-14448_v2.patch > > > Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which makes the logic ambiguous since a "provider" itself should provide logs. Suggest to directly instantiate FSHlog in RegionGroupingProvider. > W.r.t wal group name, now in RegionGroupingProvider it's using sth like "\-null\-" which is quite long and unnecessary. Suggest to directly use ".". > For more details, please refer to the initial patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)