Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 21DC2108B8 for ; Tue, 15 Sep 2015 03:28:48 +0000 (UTC) Received: (qmail 16044 invoked by uid 500); 15 Sep 2015 03:28:46 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 15666 invoked by uid 500); 15 Sep 2015 03:28:46 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 15279 invoked by uid 99); 15 Sep 2015 03:28:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Sep 2015 03:28:46 +0000 Date: Tue, 15 Sep 2015 03:28:46 +0000 (UTC) From: "Heng Chen (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14361) ReplicationSink should create Connection instances lazily MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744767#comment-14744767 ] Heng Chen commented on HBASE-14361: ----------------------------------- {quote} Does the double-checked locking as per prescription with volatile and local variable.. added links. Did same for the close too for completness sake. {quote} Thanks [~stack] for your review. I learned a lot from your patch! > ReplicationSink should create Connection instances lazily > --------------------------------------------------------- > > Key: HBASE-14361 > URL: https://issues.apache.org/jira/browse/HBASE-14361 > Project: HBase > Issue Type: Task > Components: Replication > Reporter: Nick Dimiduk > Assignee: Heng Chen > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: 14361.v3.txt, 14361.v3.txt, 14361.v3.txt, HBASE-14361-0.98.patch, HBASE-14361.patch, HBASE-14361_v1.patch, HBASE-14361_v2.patch, hmaster.log > > > Over on HBASE-12911 I have a patch that registers Connection instances with the metrics system. In both standalone server and tll client applications, I was surprised to see multiple connection objects showing up that are unused. These are pretty heavy objects, including lots of client threads for the batch pool. We should track these down and remove them -- if they're not some kind of phantom artifacts of my WIP patch over there. -- This message was sent by Atlassian JIRA (v6.3.4#6332)