Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B22001725D for ; Fri, 4 Sep 2015 08:59:46 +0000 (UTC) Received: (qmail 49804 invoked by uid 500); 4 Sep 2015 08:59:46 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 49732 invoked by uid 500); 4 Sep 2015 08:59:46 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 49717 invoked by uid 99); 4 Sep 2015 08:59:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Sep 2015 08:59:46 +0000 Date: Fri, 4 Sep 2015 08:59:46 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14359) HTable#close will hang forever if unchecked error/exception thrown in AsyncProcess#sendMultiAction MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730543#comment-14730543 ] Hudson commented on HBASE-14359: -------------------------------- SUCCESS: Integrated in HBase-1.3-IT #132 (See [https://builds.apache.org/job/HBase-1.3-IT/132/]) HBASE-14359 HTable#close will hang forever if unchecked error/exception thrown in AsyncProcess#sendMultiAction (Victor Xu) (apurtell: rev 513b37603dec42e54a7ea4add0254c71ba6c87b6) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java > HTable#close will hang forever if unchecked error/exception thrown in AsyncProcess#sendMultiAction > -------------------------------------------------------------------------------------------------- > > Key: HBASE-14359 > URL: https://issues.apache.org/jira/browse/HBASE-14359 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.14, 1.1.2 > Reporter: Yu Li > Assignee: Victor Xu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14359-0.98-v1.patch, HBASE-14359-branch-1-v1.patch, HBASE-14359-master-branch1-v1.patch, HBASE-14359-master-v1.patch > > > Currently in AsyncProcess#sendMultiAction, we only catch the RejectedExecutionException and let other error/exception go, which will cause decTaskCounter not invoked. Meanwhile, the recommendation for using HTable is to close the table in the finally clause, and HTable#close will call flushCommits and wait until all task done. > The problem is when unchecked error/exception like OutOfMemoryError thrown, taskSent will never be equal to taskDone, so AsyncProcess#waitUntilDone will never return. Especially, if autoflush is set thus no data to flush during table close, there would be no rpc call so rpcTimeOut will not break the call, and thread will wait there forever. > In our product env, the unchecked error we observed is "java.lang.OutOfMemoryError: unable to create new native thread", and we observed the client thread hang for hours -- This message was sent by Atlassian JIRA (v6.3.4#6332)