hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14524) Short-circuit comparison of rows in CellComparator
Date Wed, 30 Sep 2015 14:39:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936905#comment-14936905

Lars Francke commented on HBASE-14524:

There are no failed unit tests... and I didn't include another test because I forgot. I will
add another patch with a new test that'll check whether same cells are always returning 0.

> Short-circuit comparison of rows in CellComparator
> --------------------------------------------------
>                 Key: HBASE-14524
>                 URL: https://issues.apache.org/jira/browse/HBASE-14524
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HBASE-14524.patch
> {{CellComparator#compareRows}} compares two rows. For Scans and Gets these objects can
sometimes be exactly the same object.
> I see this (without fully understanding everything that's going on) for the first cell
in each row.
> In these circumstances I think it makes sense to short-circuit the comparison (not do
a byte comparison and class cast checks) and bail out early if the objects are identical.

This message was sent by Atlassian JIRA

View raw message