hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zephyr Guo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14490) [RpcServer] reuse request read buffer
Date Mon, 28 Sep 2015 03:04:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909991#comment-14909991
] 

Zephyr Guo commented on HBASE-14490:
------------------------------------

Thanks [~ikeda].I think you know than me about GC.But reduce creation than creating each time.So
reuse buffer seems to a optimization.

{quote}
If you stick to keeping a byte array, I suggest to use a weak reference. Also making new byte
buffer with the twice size of previous one is appropriate to reduce creation.
{quote}

It's a good suggestion.It's necessary write a new patch.

> [RpcServer] reuse request read buffer
> -------------------------------------
>
>                 Key: HBASE-14490
>                 URL: https://issues.apache.org/jira/browse/HBASE-14490
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC
>    Affects Versions: 2.0.0, 1.0.2
>            Reporter: Zephyr Guo
>            Assignee: Zephyr Guo
>              Labels: performance
>             Fix For: 2.0.0, 1.0.2
>
>         Attachments: HBASE-14490-v1.patch, HBASE-14490-v2.patch, HBASE-14490-v3.patch,
HBASE-14490-v4.patch, HBASE-14490-v5.patch, HBASE-14490-v6.patch, HBASE-14490-v7.patch
>
>
> Reuse buffer to read request.It's not necessary free data's buffer for each request.It
maybe can cause memory fragmentation.Allocate buffer also has some cost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message