hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14490) [RpcServer] reuse request read buffer
Date Sat, 26 Sep 2015 17:20:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909359#comment-14909359
] 

Anoop Sam John commented on HBASE-14490:
----------------------------------------

Using the buffer from our pool can help the put reqs. Yes at that time, the req data can be
very big.  Fine to do it as part of other issue as it need a perf run result.  This change
looks ok.  Yes as Stack mentioned pls better name that new boolean variable. I also thought
in same line as Stack and was reading again the patch, why we need the boolean.

> [RpcServer] reuse request read buffer
> -------------------------------------
>
>                 Key: HBASE-14490
>                 URL: https://issues.apache.org/jira/browse/HBASE-14490
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC
>    Affects Versions: 2.0.0, 1.1.2
>            Reporter: Zephyr Guo
>            Assignee: Zephyr Guo
>            Priority: Minor
>         Attachments: HBASE-14490-v1.patch, HBASE-14490-v2.patch, HBASE-14490-v3.patch
>
>
> Reuse buffer to read request.It's not necessary free data's buffer for each RPC.It maybe
can cause memory fragmentation.Allocate buffer also has some cost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message