hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zephyr Guo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14490) [RpcServer] reuse request read buffer
Date Fri, 25 Sep 2015 17:05:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908330#comment-14908330

Zephyr Guo commented on HBASE-14490:

The failures because I modify the {{channelIO}}.I was wrong think in it.I had deleted misleading

Should we swap in an instance of BoundedByteBufferPool here?

{{BoundedByteBufferPool}} is heavy to rpc request.
1.According to experience, size of rpc request << response on server side.
A simple example: Client request a scan, then RS maybe need to return many cells.
(we have used {{BoundedByteBufferPool}} in response.)

2.Maintain {{BoundedByteBufferPool}} need some cost.

We just need a lightweight way to reuse request buffer.Look like my patch-v2....

> [RpcServer] reuse request read buffer
> -------------------------------------
>                 Key: HBASE-14490
>                 URL: https://issues.apache.org/jira/browse/HBASE-14490
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC
>    Affects Versions: 2.0.0
>            Reporter: Zephyr Guo
>            Assignee: Zephyr Guo
>            Priority: Minor
>         Attachments: HBASE-14490-v1.patch, HBASE-14490-v2.patch
> Reuse buffer to read request.It's not necessary free data's buffer for each RPC.It maybe
can cause memory fragmentation.Allocate buffer also has some cost.

This message was sent by Atlassian JIRA

View raw message