hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14479) Apply the Leader/Followers pattern to RpcServer's Reader
Date Thu, 24 Sep 2015 10:51:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906191#comment-14906191
] 

Hadoop QA commented on HBASE-14479:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12762069/HBASE-14479.patch
  against master branch at commit 5b7894f92ba3e9ff700da1e9194ebb4774d8b71e.
  ATTACHMENT ID: 12762069

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
                  org.apache.hadoop.hbase.master.TestRollingRestart
                  org.apache.hadoop.hbase.master.TestTableLockManager
                  org.apache.hadoop.hbase.master.handler.TestEnableTableHandler
                  org.apache.hadoop.hbase.master.TestRegionPlacement
                  org.apache.hadoop.hbase.master.TestRestartCluster
                  org.apache.hadoop.hbase.master.TestMasterFailover
                  org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
                  org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure
                  org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
                  org.apache.hadoop.hbase.TestRegionRebalancing
                  org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
                  org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
                  org.apache.hadoop.hbase.master.TestDistributedLogSplitting
                  org.apache.hadoop.hbase.TestFullLogReconstruction

     {color:red}-1 core zombie tests{color}.  There are 23 zombie test(s): 	at org.apache.hadoop.hbase.util.TestHBaseFsck.testQuarantineCorruptHFile(TestHBaseFsck.java:2231)
	at org.apache.hadoop.hbase.util.TestHBaseFsck.testQuarantineMissingHFile(TestHBaseFsck.java:2373)
	at org.apache.hadoop.hbase.util.TestHBaseFsck.testFixHdfsHolesNotWorkingWithNoHdfsChecking(TestHBaseFsck.java:2152)
	at org.apache.hadoop.hbase.util.TestHBaseFsck.testCoveredStartKey(TestHBaseFsck.java:1145)
	at org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface.testIncrementHook(TestRegionObserverInterface.java:220)
	at org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface.testRegionObserver(TestRegionObserverInterface.java:124)
	at org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface.testRowMutation(TestRegionObserverInterface.java:183)
	at org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface.testCheckAndPutHooks(TestRegionObserverInterface.java:248)
	at org.apache.hadoop.hbase.TestIOFencing.testFencingAroundCompactionAfterWALSync(TestIOFencing.java:238)
	at org.apache.hadoop.hbase.client.TestFromClientSide.testJiraTest861(TestFromClientSide.java:2275)
	at org.apache.hadoop.hbase.client.TestReplicasClient.testGetNoResultNotStaleSleepRegionWithReplica(TestReplicasClient.java:370)
	at org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testSSHCleanupDaugtherRegionsOfAbortedSplit(TestSplitTransactionOnCluster.java:1003)
	at org.apache.hadoop.hbase.client.TestClientTimeouts.testAdminTimeout(TestClientTimeouts.java:108)
	at org.apache.hadoop.hbase.util.TestHBaseFsckEncryption.testFsckWithEncryption(TestHBaseFsckEncryption.java:132)
	at org.apache.hadoop.hbase.coprocessor.TestOpenTableInCoprocessor.testCoprocessorCanCreateConnectionToRemoteTableWithCustomPool(TestOpenTableInCoprocessor.java:145)
	at org.apache.hadoop.hbase.client.TestMetaWithReplicas.testShutdownHandling(TestMetaWithReplicas.java:141)
	at org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss.test(TestSplitWalDataLoss.java:141)
	at org.apache.hadoop.hbase.client.TestFromClientSide.testKeyOnlyFilter(TestFromClientSide.java:700)
	at org.apache.hadoop.hbase.util.TestRegionSplitter.testCreatePresplitTableUniform(TestRegionSplitter.java:129)
	at org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache.testOnRegionChange(TestHTableMultiplexerFlushCache.java:115)
	at org.apache.hadoop.hbase.client.TestFastFail.testFastFail(TestFastFail.java:237)
	at org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithClusters.testEnableReplicationWhenSlaveClusterDoesntHaveTable(TestReplicationAdminWithClusters.java:65)
	at org.apache.hadoop.hbase.client.TestHCM.testRegionCaching(TestHCM.java:574)
	at org.apache.hadoop.hbase.client.TestHCM.testConnectionIdle(TestHCM.java:417)
	at org.apache.hadoop.hbase.client.TestHCM.testConnectionClose(TestHCM.java:331)
	at org.apache.hadoop.hbase.client.TestHCM.testConnectionCloseAllowsInterrupt(TestHCM.java:280)
	at org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase.testMetaRebuild(TestOfflineMetaRebuildBase.java:55)
	at org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction.testMasterOpsWhileSplitting(TestEndToEndSplitTransaction.java:98)
	at org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.testMutationsWithoutWal(TestRegionServerMetrics.java:199)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15709//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15709//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15709//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15709//console

This message is automatically generated.

> Apply the Leader/Followers pattern to RpcServer's Reader
> --------------------------------------------------------
>
>                 Key: HBASE-14479
>                 URL: https://issues.apache.org/jira/browse/HBASE-14479
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC, Performance
>            Reporter: Hiroshi Ikeda
>            Assignee: Hiroshi Ikeda
>            Priority: Minor
>         Attachments: HBASE-14479.patch
>
>
> {{RpcServer}} uses multiple selectors to read data for load distribution, but the distribution
is just done by round-robin. It is uncertain, especially for long run, whether load is equally
divided and resources are used without being wasted.
> Moreover, multiple selectors may cause excessive context switches which give priority
to low latency (while we just add the requests to queues), and it is possible to reduce throughput
of the whole server.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message