hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14468) Compaction improvements: FIFO compaction policy
Date Mon, 28 Sep 2015 00:53:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909946#comment-14909946
] 

Hadoop QA commented on HBASE-14468:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12762618/HBASE-14468-v1.patch
  against master branch at commit 526520de0a9d7a29fcf1b4c521f017ca75a46cbc.
  ATTACHMENT ID: 12762618

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1789 checkstyle
errors (more than the master's current 1787 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +    LOG.info("[FIFOCompactionPolicy] Selected: "+ toCompact.size()+" asked: " + candidateFiles.size());
+  public boolean needsCompaction(Collection<StoreFile> storeFiles, List<StoreFile>
filesCompacting) {

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mob.compactions.TestMobCompactor

     {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s): 	at org.apache.hadoop.hbase.TestPartialResultsFromClientSide.testReadPointAndPartialResults(TestPartialResultsFromClientSide.java:777)
	at org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy.testTTL(TestCoprocessorScanPolicy.java:157)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15779//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15779//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15779//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15779//console

This message is automatically generated.

> Compaction improvements: FIFO compaction policy
> -----------------------------------------------
>
>                 Key: HBASE-14468
>                 URL: https://issues.apache.org/jira/browse/HBASE-14468
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14468-v1.patch
>
>
> FIFO compaction policy selects only files which have all cells expired. The column family
MUST have non-default TTL. One of the use cases for this policy is when we need to store raw
data which will be post-processed later and discarded completely after quite short period
of time. Raw time-series vs. time-based rollup aggregates and compacted time-series. We collect
raw time-series and store them into CF with FIFO compaction policy, periodically we run  task
which creates rollup aggregates and compacts time-series, the original raw data can be discarded
after that.
> See: https://github.com/facebook/rocksdb/wiki/FIFO-compaction-style



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message