hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14442) MultiTableInputFormatBase.getSplits dosenot build split for a scan whose startRow=stopRow=(startRow of a region)
Date Mon, 21 Sep 2015 16:35:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900940#comment-14900940
] 

Nick Dimiduk commented on HBASE-14442:
--------------------------------------

It's good to test the result of getSplits, but probably an end-to-end test, something that
verifies all the expected data is returned will help us maintain correctness in the long run.

> MultiTableInputFormatBase.getSplits dosenot build split for a scan whose startRow=stopRow=(startRow
of a region)
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14442
>                 URL: https://issues.apache.org/jira/browse/HBASE-14442
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 1.1.2
>            Reporter: Nathan
>            Assignee: Nathan
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> I created a Scan whose startRow and stopRow are the same with a region's startRow, then
I found no map was built. 
> The following is the source code of this condtion:
> (startRow.length == 0 || keys.getSecond()[i].length == 0 ||
>                     Bytes.compareTo(startRow, keys.getSecond()[i]) < 0) &&
>                     (stopRow.length == 0 || Bytes.compareTo(stopRow,
>                             keys.getFirst()[i]) > 0)
> I think  a "=" should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message