hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14404) Backport HBASE-14098 (Allow dropping caches behind compactions) to 0.98
Date Thu, 24 Sep 2015 09:52:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906131#comment-14906131
] 

Hadoop QA commented on HBASE-14404:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12762100/v3-v2.diff
  against master branch at commit 5b7894f92ba3e9ff700da1e9194ebb4774d8b71e.
  ATTACHMENT ID: 12762100

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15716//console

This message is automatically generated.

> Backport HBASE-14098 (Allow dropping caches behind compactions) to 0.98
> -----------------------------------------------------------------------
>
>                 Key: HBASE-14404
>                 URL: https://issues.apache.org/jira/browse/HBASE-14404
>             Project: HBase
>          Issue Type: Task
>            Reporter: Andrew Purtell
>            Assignee: Liu Shaohui
>             Fix For: 0.98.15
>
>         Attachments: HBASE-14404-0.98-v3.diff, HBASE-14404-0.98.patch, HBASE-14404-0.98.patch,
v3-v2.diff
>
>
> HBASE-14098 adds a new configuration toggle - "hbase.hfile.drop.behind.compaction" -
which if set to "true" tells compactions to drop pages from the OS blockcache after write.
 It's on by default where committed so far but a backport to 0.98 would default it to off.
(The backport would also retain compat methods to LimitedPrivate interface StoreFileScanner.)
What could make it a controversial change in 0.98 is it changes the default setting of 'hbase.regionserver.compaction.private.readers'
from "false" to "true".  I think it's fine, we use private readers in production. They're
stable and do not present perf issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message