hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-14404) Backport HBASE-14098 (Allow dropping caches behind compactions) to 0.98
Date Sat, 19 Sep 2015 05:57:04 GMT

     [ https://issues.apache.org/jira/browse/HBASE-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Purtell updated HBASE-14404:
-----------------------------------
       Resolution: Invalid
         Assignee:     (was: Andrew Purtell)
    Fix Version/s:     (was: 0.98.15)
           Status: Resolved  (was: Patch Available)

The test results are not good. Take TestTags for example:
{noformat}
Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 28.383 sec <<< FAILURE!
- in org.apache.hadoop.hbase.regionserver.TestTags
testFlushAndCompactionwithCombinations(org.apache.hadoop.hbase.regionserver.TestTags)  Time
elapsed: 3.899 sec  <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:743)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:555)
	at org.junit.Assert.assertEquals(Assert.java:542)
	at org.apache.hadoop.hbase.regionserver.TestTags.testFlushAndCompactionwithCombinations(TestTags.java:326)

Results :

Failed tests: 
  TestTags.testFlushAndCompactionwithCombinations:326 expected:<1> but was:<0>
{noformat}

This change triggers that failure (and the others). Checked the logs and there are no unexpected
errors or warnings and no occurrences of the new debug log line "Unable to set drop behind
on ..." to indicate anything amiss. Yet we don't read back the data we are expecting.

No interest in proceeding further, resolving as Invalid. 

> Backport HBASE-14098 (Allow dropping caches behind compactions) to 0.98
> -----------------------------------------------------------------------
>
>                 Key: HBASE-14404
>                 URL: https://issues.apache.org/jira/browse/HBASE-14404
>             Project: HBase
>          Issue Type: Task
>            Reporter: Andrew Purtell
>         Attachments: HBASE-14404-0.98.patch, HBASE-14404-0.98.patch
>
>
> HBASE-14098 adds a new configuration toggle - "hbase.hfile.drop.behind.compaction" -
which if set to "true" tells compactions to drop pages from the OS blockcache after write.
 It's on by default where committed so far but a backport to 0.98 would default it to off.
(The backport would also retain compat methods to LimitedPrivate interface StoreFileScanner.)
What could make it a controversial change in 0.98 is it changes the default setting of 'hbase.regionserver.compaction.private.readers'
from "false" to "true".  I think it's fine, we use private readers in production. They're
stable and do not present perf issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message