hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14398) Create the fake keys required in the scan path to avoid copy to byte[]
Date Tue, 29 Sep 2015 22:19:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936020#comment-14936020
] 

stack commented on HBASE-14398:
-------------------------------

+1 too. This is a crazy amount of types. Hopefully we can simplify later.

One thought I had looking at this ByteBufferedCell Interface is how unwieldy the method names
are. getTagsPositionInByteBuffer is a bit of a mouth full. What was the reason that we could
not just use the Cell#getTagsOffset method and use its offset as 'index' into the backing
BB?

Thanks [~ram_krish] and [~anoop.hbase]

> Create the fake keys required in the scan path to avoid copy to byte[]
> ----------------------------------------------------------------------
>
>                 Key: HBASE-14398
>                 URL: https://issues.apache.org/jira/browse/HBASE-14398
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14398.patch, HBASE-14398_1.patch
>
>
> Already we have created some fake keys for the ByteBufferedCells so that we can avoid
the copy requried to create fake keys. This JIRA aims to fill up all such places so that the
Offheap BBs are not copied to onheap byte[].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message