hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
Date Thu, 24 Sep 2015 16:23:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906584#comment-14906584
] 

Nick Dimiduk commented on HBASE-14394:
--------------------------------------

[~srikanth235] Is {{setConnection}} only called from {{MultiTableInputFormatBase}}? If so,
it can be added at protected visibility. Either way, adding a docstring should help future
maintainers to understand what's going on.

[~jerryhe] I don't mind adding the method, so long as it's added with good reason, is considered
thoughtfully as part of the API of a public interface, and is documented appropriately.

However, on the {{close()}} descriptor, we need to maintain 100% source compatibility for
patch releases, so 1.0, and 1.1 branch (and 0.98 actually), patches must not change the throws
signature of this method. Mind adding an addendum for those release versions that addresses
the visibility, docstring, and interface issues?

For your reference, I generate the compatibility report linked in the dev thread using the
tool {{dev-support/check_compatibility.sh}} on master. Thanks folks.

> Properly close the connection after reading records from table.
> ---------------------------------------------------------------
>
>                 Key: HBASE-14394
>                 URL: https://issues.apache.org/jira/browse/HBASE-14394
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>            Priority: Minor
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3
>
>         Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, HBASE-14394_v3.patch, HBASE-14394_v4.patch
>
>
> This was brought to notice by one of our observant customers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message