hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14361) ReplicationSink should create Connection instances lazily
Date Tue, 15 Sep 2015 09:03:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745090#comment-14745090
] 

Hadoop QA commented on HBASE-14361:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12755902/14361.v3.txt
  against master branch at commit 72b4c906b806236cd5fcf5a69f12628d00941df9.
  ATTACHMENT ID: 12755902

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1835 checkstyle
errors (more than the master's current 1834 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
                  org.apache.hadoop.hbase.TestStochasticBalancerJmxMetrics

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15596//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15596//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15596//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15596//console

This message is automatically generated.

> ReplicationSink should create Connection instances lazily
> ---------------------------------------------------------
>
>                 Key: HBASE-14361
>                 URL: https://issues.apache.org/jira/browse/HBASE-14361
>             Project: HBase
>          Issue Type: Task
>          Components: Replication
>            Reporter: Nick Dimiduk
>            Assignee: Heng Chen
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>
>         Attachments: 14361.v3.txt, 14361.v3.txt, 14361.v3.txt, 14361.v3.txt, HBASE-14361-0.98.patch,
HBASE-14361.patch, HBASE-14361_v1.patch, HBASE-14361_v2.patch, hmaster.log
>
>
> Over on HBASE-12911 I have a patch that registers Connection instances with the metrics
system. In both standalone server and tll client applications, I was surprised to see multiple
connection objects showing up that are unused. These are pretty heavy objects, including lots
of client threads for the batch pool. We should track these down and remove them -- if they're
not some kind of phantom artifacts of my WIP patch over there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message