hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heng Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14361) ReplicationSink should create Connection instances lazily
Date Tue, 15 Sep 2015 03:28:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744767#comment-14744767
] 

Heng Chen commented on HBASE-14361:
-----------------------------------

{quote}
Does the double-checked locking as per prescription with volatile and local variable.. added
links. Did same for the close too for completness sake.
{quote}

Thanks [~stack] for your review. I learned a lot from your patch!

> ReplicationSink should create Connection instances lazily
> ---------------------------------------------------------
>
>                 Key: HBASE-14361
>                 URL: https://issues.apache.org/jira/browse/HBASE-14361
>             Project: HBase
>          Issue Type: Task
>          Components: Replication
>            Reporter: Nick Dimiduk
>            Assignee: Heng Chen
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>
>         Attachments: 14361.v3.txt, 14361.v3.txt, 14361.v3.txt, HBASE-14361-0.98.patch,
HBASE-14361.patch, HBASE-14361_v1.patch, HBASE-14361_v2.patch, hmaster.log
>
>
> Over on HBASE-12911 I have a patch that registers Connection instances with the metrics
system. In both standalone server and tll client applications, I was surprised to see multiple
connection objects showing up that are unused. These are pretty heavy objects, including lots
of client threads for the batch pool. We should track these down and remove them -- if they're
not some kind of phantom artifacts of my WIP patch over there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message