hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14359) HTable#close will hang forever if unchecked error/exception thrown in AsyncProcess#sendMultiAction
Date Thu, 03 Sep 2015 15:20:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729236#comment-14729236
] 

Hadoop QA commented on HBASE-14359:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12753980/HBASE-14359-branch-1-v1.patch
  against branch-1 branch at commit 3341f13e71a25bf3f8eb5a6a57ce330b3d8a3495.
  ATTACHMENT ID: 12753980

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 5 zombie test(s): 	at org.apache.hadoop.hbase.security.access.TestAccessControlFilter.testQualifierAccess(TestAccessControlFilter.java:96)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15405//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15405//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15405//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15405//console

This message is automatically generated.

> HTable#close will hang forever if unchecked error/exception thrown in AsyncProcess#sendMultiAction
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14359
>                 URL: https://issues.apache.org/jira/browse/HBASE-14359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.14, 1.1.2
>            Reporter: Yu Li
>            Assignee: Victor Xu
>         Attachments: HBASE-14359-0.98-v1.patch, HBASE-14359-branch-1-v1.patch, HBASE-14359-master-branch1-v1.patch,
HBASE-14359-master-v1.patch
>
>
> Currently in AsyncProcess#sendMultiAction, we only catch the RejectedExecutionException
and let other error/exception go, which will cause decTaskCounter not invoked. Meanwhile,
the recommendation for using HTable is to close the table in the finally clause, and HTable#close
will call flushCommits and wait until all task done.
> The problem is when unchecked error/exception like OutOfMemoryError thrown, taskSent
will never be equal to taskDone, so AsyncProcess#waitUntilDone will never return. Especially,
if autoflush is set thus no data to flush during table close, there would be no rpc call so
rpcTimeOut will not break the call, and thread will wait there forever.
> In our product env, the unchecked error we observed is "java.lang.OutOfMemoryError: unable
to create new native thread", and we observed the client thread hang for hours



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message