hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14349) pre-commit zombie finder is overly broad
Date Tue, 08 Sep 2015 12:48:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734758#comment-14734758
] 

Sean Busbey commented on HBASE-14349:
-------------------------------------

current zombie detector:

{code}
  ZOMBIE_TESTS_COUNT=`jps | grep surefirebooter | wc -l`
  if [[ $ZOMBIE_TESTS_COUNT != 0 ]] ; then
    #It seems sometimes the tests are not dying immediately. Let's give them 30s
    echo "Suspicious java process found - waiting 30s to see if there are just slow to stop"
    sleep 30
    ZOMBIE_TESTS_COUNT=`jps | grep surefirebooter | wc -l`
    if [[ $ZOMBIE_TESTS_COUNT != 0 ]] ; then
      echo "There are $ZOMBIE_TESTS_COUNT zombie tests, they should have been killed by surefire
but survived"
      echo "************ BEGIN zombies jstack extract"
      ZB_STACK=`jps | grep surefirebooter | cut -d ' ' -f 1 | xargs -n 1 jstack | grep ".test"
| grep "\.java"`
      jps | grep surefirebooter | cut -d ' ' -f 1 | xargs -n 1 jstack
      echo "************ END  zombies jstack extract"
      JIRA_COMMENT="$JIRA_COMMENT
     {color:red}-1 core zombie tests{color}.  There are ${ZOMBIE_TESTS_COUNT} zombie test(s):
${ZB_STACK}"
      BAD=1
      jps | grep surefirebooter | cut -d ' ' -f 1 | xargs kill -9
    else
      echo "We're ok: there is no zombie test, but some tests took some time to stop"
    fi
  else
    echo "We're ok: there is no zombie test"
  fi
{code}

the jps entries look like

{code}
Every 2.0s: jps | grep surefirebooter                                                    
                                                                                        Tue
Sep  8 07:47:48 2015

36463 surefirebooter7254413731964488287.jar

{code}

so there's nothing that screams "hbase only." Anyone have any ideas? I guess we could track
pids after we do the jstack dump and limit to those that look like hbase tests?

> pre-commit zombie finder is overly broad
> ----------------------------------------
>
>                 Key: HBASE-14349
>                 URL: https://issues.apache.org/jira/browse/HBASE-14349
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Sean Busbey
>            Priority: Critical
>
> Zombie detector is flagging processes from builds that aren't ours.
> ex from HBASE-14337:
> {code}
> -1 core zombie tests. There are 4 zombie test(s): at org.apache.reef.io.network.DeprecatedNetworkConnectionServiceTest.testMultithreadedSharedConnMessagingNetworkConnServiceRate(DeprecatedNetworkConnectionServiceTest.java:343)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message