hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14331) a single callQueue related improvements
Date Wed, 09 Sep 2015 04:58:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736169#comment-14736169

stack commented on HBASE-14331:

These are the tests that went zombie

kalashnikov:hbase.git stack$ python dev-support/findHangingTests.py https://builds.apache.org/job/PreCommit-HBASE-Build/15468//consoleText
Fetching the console output from the URL
Printing hanging tests
Hanging test : org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot
Hanging test : org.apache.hadoop.hbase.snapshot.TestMobExportSnapshot
Hanging test : org.apache.hadoop.hbase.mob.compactions.TestMobCompactor
Hanging test : org.apache.hadoop.hbase.mob.mapreduce.TestMobSweepJob
Hanging test : org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel
Hanging test : org.apache.hadoop.hbase.util.TestHBaseFsck
Hanging test : org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded
Hanging test : org.apache.hadoop.hbase.snapshot.TestExportSnapshot
Printing Failing tests
Failing test : org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential

Let me retry patch.

> a single callQueue related improvements
> ---------------------------------------
>                 Key: HBASE-14331
>                 URL: https://issues.apache.org/jira/browse/HBASE-14331
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC, Performance
>            Reporter: Hiroshi Ikeda
>            Assignee: Hiroshi Ikeda
>            Priority: Minor
>         Attachments: BlockingQueuesPerformanceTestApp-output.pdf, BlockingQueuesPerformanceTestApp-output.txt,
BlockingQueuesPerformanceTestApp.java, CallQueuePerformanceTestApp.java, HBASE-14331.patch,
SemaphoreBasedBlockingQueue.java, SemaphoreBasedLinkedBlockingQueue.java, SemaphoreBasedPriorityBlockingQueue.java
> {{LinkedBlockingQueue}} well separates locks between the {{take}} method and the {{put}}
method, but not between takers, and not between putters. These methods are implemented to
take locks at the almost beginning of their logic. HBASE-11355 introduces multiple call-queues
to reduce such possible congestion, but I doubt that it is required to stick to {{BlockingQueue}}.
> There are the other shortcomings of using {{BlockingQueue}}. When using multiple queues,
since {{BlockingQueue}} blocks threads it is required to prepare enough threads for each queue.
It is possible that there is a queue starving for threads while there is another queue where
threads are idle. Even if you can tune parameters to avoid such situations, the tuning is
not so trivial.
> I suggest using a single {{ConcurrentLinkedQueue}} with {{Semaphore}}.

This message was sent by Atlassian JIRA

View raw message