hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yerui Sun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
Date Wed, 02 Sep 2015 02:29:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726625#comment-14726625

Yerui Sun commented on HBASE-14229:

[~yuzhihong@gmail.com], thanks a lot for your help to test and merge this patch. 

I ran through test suite on 0.98 and master branches and passed locally, as you did, but the
QA failed. It's really confused me, could you please explain a bit more about why QA didn't
work correctly, and how could I avoid these failure happened again with future patches?

> Flushing canceled by coprocessor still leads to memstoreSize set down
> ---------------------------------------------------------------------
>                 Key: HBASE-14229
>                 URL: https://issues.apache.org/jira/browse/HBASE-14229
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1
>            Reporter: Yerui Sun
>            Assignee: Yerui Sun
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>         Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, HBASE-14229-branch-1-v2.patch,
HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1.patch, HBASE-14229-master.patch
> A Coprocessor override "public InternalScanner preFlush(final Store store, final InternalScanner
scanner)" and return NULL when calling this method, will cancel flush request, leaving snapshot
un-flushed, and no new storefile created. But the HRegion.internalFlushCache still set down
memstoreSize to 0 by totalFlushableSize. 
> If there's no write requests anymore, the memstoreSize will remaining as 0, and no more
flush quests will be processed because of the checking of memstoreSize.get() <=0 at the
beginning of internalFlushCache.
> This issue may not cause data loss, but it will confuse coprocessor users. If we argree
with this, I'll apply a patch later.

This message was sent by Atlassian JIRA

View raw message