hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jingcheng Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14227) Fold special cased MOB APIs into existing APIs
Date Fri, 25 Sep 2015 01:41:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907366#comment-14907366
] 

Jingcheng Du commented on HBASE-14227:
--------------------------------------

Sorry for the late response. I'm ok with the current patch.
I am currently work on implementing mob compaction with procedure. After that we can use Admin.execProcedure
to invoke the mob compaction instead of the current APIs (compactMob, majorCompactMob, etc.).
So what do you guys think of this? Which way should we choose?
# Apply the code of current patch.
# Use Admin.execProcedure after the procedure mob compaction is finished.

Please advise. Thanks a lot!

> Fold special cased MOB APIs into existing APIs
> ----------------------------------------------
>
>                 Key: HBASE-14227
>                 URL: https://issues.apache.org/jira/browse/HBASE-14227
>             Project: HBase
>          Issue Type: Task
>          Components: mob
>    Affects Versions: 2.0.0
>            Reporter: Andrew Purtell
>            Assignee: Heng Chen
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14227.patch, HBASE-14227_v1.patch, HBASE-14227_v2.patch, HBASE-14227_v3.patch,
HBASE-14227_v4.patch, HBASE-14227_v5.patch, HBASE-14227_v5.patch
>
>
> There are a number of APIs that came in with MOB that are not new actions for HBase,
simply new actions for a MOB implementation:
> - compactMob
> - compactMobs
> - majorCompactMob
> - majorCompactMobs
> - getMobCompactionState
> And in HBaseAdmin:
> - validateMobColumnFamily
> Remove these special cases from the Admin API where possible by folding them into existing
APIs.
> We definitely don't need one method for a singleton and another for collections.
> Ideally we will not have any APIs named *Mob when finished, whether MOBs are in use on
a table or not should be largely an internal detail. Exposing as schema option would be fine,
this conforms to existing practice for other features.
> Marking critical because I think removing the *Mob special cased APIs should be a precondition
for release of this feature either in 2.0 or as a backport.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message