hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12298) Support BB usage in PrefixTree
Date Fri, 11 Sep 2015 11:59:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740649#comment-14740649

ramkrishna.s.vasudevan commented on HBASE-12298:

bq.Need change the method name as per the change in parameter?
bq.I see the special case just down. Pls add some comments why it is always BBCell
Yes added.
bq.// TODO : See if we can add only one API to do all this - I see... We dont have positional
get API.. It will be easy to add IMO. 
As part of this JIRA? I thought we can do that in another JIRA. Let me see.
bq.This pair comes from? The BB and offset is been properly taken from this? (where?)
Comes from PrefixTreeArraySearcher.
bq.PrefixTreeCell - Why it has to keep a ref to ByteBuff block?
Why not use asSubBuffer and keep ref to ByteBuffer for value rather than having a Pair and
using it every time?
Not sure I got your meaning.  From the setCurrentBuffer call from the hfileReader we only
have the Bytebuff and that is set in the PrefixTreeArrayScanner which is of type PrefixTreeCell.
All the calculations happen in the PRefixTreeArrayScanner.  

> Support BB usage in PrefixTree
> ------------------------------
>                 Key: HBASE-12298
>                 URL: https://issues.apache.org/jira/browse/HBASE-12298
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-12298.patch, HBASE-12298_1.patch, HBASE-12298_2.patch, HBASE-12298_3.patch,
HBASE-12298_4 (1).patch, HBASE-12298_4 (1).patch, HBASE-12298_4 (1).patch, HBASE-12298_4 (1).patch,
HBASE-12298_4 (1).patch, HBASE-12298_4.patch, HBASE-12298_4.patch, HBASE-12298_4.patch, HBASE-12298_4.patch

This message was sent by Atlassian JIRA

View raw message