hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Liochon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11590) use a specific ThreadPoolExecutor
Date Thu, 17 Sep 2015 19:59:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804373#comment-14804373

Nicolas Liochon commented on HBASE-11590:

If we cut down the timeout, it's more or less equivalent of not having a thread pool at all.

One of the things I don't like in many solutions (the TPE I wrote myself included) is that
we have a race condition: we may create a thread even if it's not needed.
I'm off for 3 days, but I will try to find a reasonable solution next week.

> use a specific ThreadPoolExecutor
> ---------------------------------
>                 Key: HBASE-11590
>                 URL: https://issues.apache.org/jira/browse/HBASE-11590
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, Performance
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Minor
>             Fix For: 2.0.0
>         Attachments: tp.patch
> The JDK TPE creates all the threads in the pool. As a consequence, we create (by default)
256 threads even if we just need a few.
> The attached TPE create threads only if we have something in the queue.
> On a PE test with replica on, it improved the 99 latency percentile by 5%. 
> Warning: there are likely some race conditions, but I'm posting it here because there
is may be an implementation available somewhere we can use, or a good reason not to do that.
So feedback welcome as usual. 

This message was sent by Atlassian JIRA

View raw message