hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Liochon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10449) Wrong execution pool configuration in HConnectionManager
Date Wed, 16 Sep 2015 05:25:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746897#comment-14746897
] 

Nicolas Liochon commented on HBASE-10449:
-----------------------------------------

As I understand the doc, if we do that we create maxThreads and then reject all the tasks.
Not really useful.
But the patch in HBASE-14433 seems ok:
- we create up to core threads (Runtime.getRuntime().availableProcessors()). If we have 10
tasks in parallel we still have Runtime.getRuntime().availableProcessors() threads.
- the expire quite quickly (because we do allowCoreThreadTimeOut(true);)

May be we should set maxThreads to coreThreads as well and increase HConstants.DEFAULT_HBASE_CLIENT_MAX_TOTAL_TASKS.

But I'm +1 with HBASE-14433 as it is now.

> Wrong execution pool configuration in HConnectionManager
> --------------------------------------------------------
>
>                 Key: HBASE-10449
>                 URL: https://issues.apache.org/jira/browse/HBASE-10449
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0, 0.99.0, 0.96.1.1
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Critical
>             Fix For: 0.98.0, 0.96.2, 0.99.0
>
>         Attachments: HBASE-10449.v1.patch
>
>
> There is a confusion in the configuration of the pool. The attached patch fixes this.
This may change the client performances, as we were using a single thread.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message