Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B83E110EC3 for ; Wed, 26 Aug 2015 17:03:46 +0000 (UTC) Received: (qmail 34829 invoked by uid 500); 26 Aug 2015 17:03:46 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 34786 invoked by uid 500); 26 Aug 2015 17:03:46 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 34773 invoked by uid 99); 26 Aug 2015 17:03:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2015 17:03:46 +0000 Date: Wed, 26 Aug 2015 17:03:46 +0000 (UTC) From: "Yu Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14306) Refine RegionGroupingProvider: fix issues and make it more scalable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715159#comment-14715159 ] Yu Li commented on HBASE-14306: ------------------------------- Sorry, wrong link above, should be [this one|https://reviews.apache.org/r/37762/] > Refine RegionGroupingProvider: fix issues and make it more scalable > ------------------------------------------------------------------- > > Key: HBASE-14306 > URL: https://issues.apache.org/jira/browse/HBASE-14306 > Project: HBase > Issue Type: Improvement > Components: wal > Reporter: Yu Li > Assignee: Yu Li > Attachments: HBASE-14306.patch, HBASE-14306_v2.patch > > > There're multiple issues in RegionGroupingProvider, including: > * The provider cache in it is using byte array as the key of ConcurrentHashMap, which is not right (the reason is [here|http://stackoverflow.com/questions/1058149/using-a-byte-array-as-hashmap-key-java]) > * It's using IdentityGroupingStrategy to get group and use it as key of the cache, which means the cache will include an entry for each region. This is especially unnecessary when using BoundedRegionGroupingProvider > Besides fixing the above issues, I suggest to change BoundedRegionGroupingProvider from a *provider* to a pluggable *strategy*, which will make the whole picture much more clear. > For more details, please refer to the patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)