Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 19E7318426 for ; Fri, 21 Aug 2015 15:54:59 +0000 (UTC) Received: (qmail 91504 invoked by uid 500); 21 Aug 2015 15:54:46 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 91448 invoked by uid 500); 21 Aug 2015 15:54:46 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 91230 invoked by uid 99); 21 Aug 2015 15:54:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Aug 2015 15:54:46 +0000 Date: Fri, 21 Aug 2015 15:54:46 +0000 (UTC) From: "Sean Busbey (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14281) ArrayIndexOutOfBoundsException in CellComparator#getMinimumMidpointArray, part 2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706911#comment-14706911 ] Sean Busbey commented on HBASE-14281: ------------------------------------- thanks for filing this Michael. can you post up your additional fixes as a patch here? > ArrayIndexOutOfBoundsException in CellComparator#getMinimumMidpointArray, part 2 > -------------------------------------------------------------------------------- > > Key: HBASE-14281 > URL: https://issues.apache.org/jira/browse/HBASE-14281 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 1.0.0, 1.0.1, 1.0.2 > Reporter: Michael Rose > > Follow-on issue for HBASE-13329: CellComparator#getMinimumMidpointArray seems to have had a necessary change omitted and the patch only covered one of the two places diffIdx could overflow the short. > For some background, we ran into the HBASE-13329 issue where a flush would cause a regionserver abort. After abort, the region in question would almost indefinitely sit in the FAILED_OPEN state. Applying the patch from HBASE-13329 didn't solve the issue, but I noticed a comment in that issue which applied the same change in CellComparator#getMinimumMidpointArray, but the change was omitted from the attached patch. > RS abort for reference: > slave3.xxx.xxx.xxx,60020,1440131603772: Replay of WAL required. Forcing server shutdown > org.apache.hadoop.hbase.DroppedSnapshotException: region: deduplication,P\xDFt\x10\x053e73ceff5a2717d2ba76887ea21a2a8e353d1372\xFE,1438362391124.2bb6a602be6b1bfcea0508af4ba42235. > at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2243) > at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1972) > at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1935) > at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:1833) > at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:452) > at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:413) > at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$800(MemStoreFlusher.java:70) > at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:229) > at java.lang.Thread.run(Thread.java:745) > Caused by: java.lang.NegativeArraySizeException > at org.apache.hadoop.hbase.CellComparator.getMinimumMidpointArray(CellComparator.java:494) > at org.apache.hadoop.hbase.CellComparator.getMidpoint(CellComparator.java:448) > at org.apache.hadoop.hbase.io.hfile.HFileWriterV2.finishBlock(HFileWriterV2.java:165) > at org.apache.hadoop.hbase.io.hfile.HFileWriterV2.checkBlockBoundary(HFileWriterV2.java:146) > at org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:263) > at org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:949) -- This message was sent by Atlassian JIRA (v6.3.4#6332)