Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 13 Aug 2015 07:06:46 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12855387.1439335121000.53670.1439449606654@Atlassian.JIRA>
In-Reply-To: <JIRA.12855387.1439335121000@Atlassian.JIRA>
References: <JIRA.12855387.1439335121000@Atlassian.JIRA>
 <JIRA.12855387.1439335121404@arcas>
Subject: [jira] [Commented] (HBASE-14214) list_labels shouldn't raise
 ArgumentError if no labels are defined
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694820#comment-14694820 ] 

Hadoop QA commented on HBASE-14214:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12750068/HBASE-14214.patch
  against master branch at commit a399ac9c4f76dccebb3476c418aac68667dee545.
  ATTACHMENT ID: 12750068

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15081//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15081//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15081//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15081//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15081//console

This message is automatically generated.

> list_labels shouldn't raise ArgumentError if no labels are defined 
> -------------------------------------------------------------------
>
>                 Key: HBASE-14214
>                 URL: https://issues.apache.org/jira/browse/HBASE-14214
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-14214.patch
>
>
> list_labels shouldn't raise ArgumentError if no labels are defined. The empty list is a valid return case, and anyway ArgumentError should be used when arguments to the command are erroneous. Here the command is well formed:
> {noformat}
> hbase(main):001:0> list_labels
> ERROR: No auth label defined
> Here is some help for this command:
> List the visibility labels defined in the system.
> Optional regular expression parameter could be used to filter the labels being returned.
> Syntax : list_labels
> For example:
>     hbase> list_labels 'secret.*'
>     hbase> list_labels
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)