Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C422B182E8 for ; Tue, 11 Aug 2015 20:13:50 +0000 (UTC) Received: (qmail 25165 invoked by uid 500); 11 Aug 2015 20:13:47 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 25117 invoked by uid 500); 11 Aug 2015 20:13:47 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 25103 invoked by uid 99); 11 Aug 2015 20:13:47 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Aug 2015 20:13:47 +0000 Date: Tue, 11 Aug 2015 20:13:47 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14206) MultiRowRangeFilter returns records whose rowKeys are out of allowed ranges MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682408#comment-14682408 ] Hudson commented on HBASE-14206: -------------------------------- FAILURE: Integrated in HBase-TRUNK #6714 (See [https://builds.apache.org/job/HBase-TRUNK/6714/]) HBASE-14206 MultiRowRangeFilter returns records whose rowKeys are out of allowed ranges (Anton Nazaruk) (tedyu: rev a2dbe31b269a9813971ffa76af400d303cb85d63) * hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestMultiRowRangeFilter.java > MultiRowRangeFilter returns records whose rowKeys are out of allowed ranges > --------------------------------------------------------------------------- > > Key: HBASE-14206 > URL: https://issues.apache.org/jira/browse/HBASE-14206 > Project: HBase > Issue Type: Bug > Affects Versions: 1.1.0 > Environment: linux, java7 > Reporter: Anton Nazaruk > Assignee: Anton Nazaruk > Priority: Critical > Labels: filter > Fix For: 2.0.0, 1.2.0, 1.1.2, 1.3.0 > > Attachments: 14206-branch-1.txt, 14206-test.patch, 14206-v1.txt > > > I haven't found a way to attach test program to JIRA issue, so put it below : > {code} > public class MultiRowRangeFilterTest { > > byte[] key1Start = new byte[] {-3}; > byte[] key1End = new byte[] {-2}; > byte[] key2Start = new byte[] {5}; > byte[] key2End = new byte[] {6}; > byte[] badKey = new byte[] {-10}; > @Test > public void testRanges() throws IOException { > MultiRowRangeFilter filter = new MultiRowRangeFilter(Arrays.asList( > new MultiRowRangeFilter.RowRange(key1Start, true, key1End, false), > new MultiRowRangeFilter.RowRange(key2Start, true, key2End, false) > )); > filter.filterRowKey(badKey, 0, 1); > /* > * FAILS -- includes BAD key! > * Expected :SEEK_NEXT_USING_HINT > * Actual :INCLUDE > * */ > assertEquals(Filter.ReturnCode.SEEK_NEXT_USING_HINT, filter.filterKeyValue(null)); > } > } > {code} > It seems to happen on 2.0.0-SNAPSHOT too, but I wasn't able to link one with included class. > I have played some time with algorithm, and found that quick fix may be applied to "getNextRangeIndex(byte[] rowKey)" method (hbase-client:1.1.0) : > {code} > if (insertionPosition == 0 && !rangeList.get(insertionPosition).contains(rowKey)) { > return ROW_BEFORE_FIRST_RANGE; > } > // FIX START > if(!this.initialized) { > this.initialized = true; > } > // FIX END > return insertionPosition; > {code} > Thanks, hope it will help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)