Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4CB26186AC for ; Fri, 14 Aug 2015 06:13:46 +0000 (UTC) Received: (qmail 11342 invoked by uid 500); 14 Aug 2015 06:13:46 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 11292 invoked by uid 500); 14 Aug 2015 06:13:46 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 11278 invoked by uid 99); 14 Aug 2015 06:13:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Aug 2015 06:13:46 +0000 Date: Fri, 14 Aug 2015 06:13:46 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14144) Bloomfilter path to work with Byte buffered cells MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696539#comment-14696539 ] Anoop Sam John commented on HBASE-14144: ---------------------------------------- +1.. Just add some comments to these classes that they are not real and used for seek/reseek.. Just in case when some one sees this code later, they should get to know what these cells mean for.. Add on commit pls. > Bloomfilter path to work with Byte buffered cells > ------------------------------------------------- > > Key: HBASE-14144 > URL: https://issues.apache.org/jira/browse/HBASE-14144 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch, HBASE-14144_3.patch, HBASE-14144_4.patch, HBASE-14144_5.patch, HBASE-14144_6.patch > > > This JIRA is to check if there will be a need to make the bloom filters to work with ByteBuffer cells. During POC this path created lot of duplicated code but considering other refactorings done in this path may lead to less duplication. This JIRA is a placeholder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)