Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 21 Aug 2015 04:42:46 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12726575.1404995790000.127060.1440132166101@Atlassian.JIRA>
In-Reply-To: <JIRA.12726575.1404995790000@Atlassian.JIRA>
References: <JIRA.12726575.1404995790000@Atlassian.JIRA>
 <JIRA.12726575.1404995790058@arcas>
Subject: [jira] [Commented] (HBASE-11490) In HBase Shell set_peer_tableCFs,
 if the tableCFS is null, it will be wrong
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706226#comment-14706226 ] 

Anoop Sam John commented on HBASE-11490:
----------------------------------------

patch looks ok.
nit : 
tableCFs = new byte[0];
Instead use HConstants.EMPTY_BYTE_ARRAY.

Will be better to add an FT test case as Ashish suggested.

> In HBase Shell set_peer_tableCFs, if the tableCFS is null, it will be wrong
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-11490
>                 URL: https://issues.apache.org/jira/browse/HBASE-11490
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 0.99.0
>            Reporter: Qianxi Zhang
>            Assignee: Qianxi Zhang
>            Priority: Minor
>         Attachments: HBASE_11490_trunk_v1.patch
>
>
> In HBase Shell set_peer_tableCFs, If the tableCFS is null, it will throw NPE
>  # set all tables to be replicable for a peer
>     hbase> set_peer_tableCFs '1', ""
>     hbase> set_peer_tableCFs '1'
> ReplicationAdmin#199
> {code}
>   public void setPeerTableCFs(String id, String tableCFs) throws ReplicationException {
>     this.replicationPeers.setPeerTableCFsConfig(id, tableCFs);
>   }
> {code}
> ReplicationPeersZKImpl#177
> {code}
>   public void setPeerTableCFsConfig(String id, String tableCFsStr) throws ReplicationException {
>     try {
>       if (!peerExists(id)) {
>         throw new IllegalArgumentException("Cannot set peer tableCFs because id=" + id
>             + " does not exist.");
>       }
>       String tableCFsZKNode = getTableCFsNode(id);
>       byte[] tableCFs = Bytes.toBytes(tableCFsStr);
>       if (ZKUtil.checkExists(this.zookeeper, tableCFsZKNode) != -1) {
>         ZKUtil.setData(this.zookeeper, tableCFsZKNode, tableCFs);
>       } else {
>         ZKUtil.createAndWatch(this.zookeeper, tableCFsZKNode, tableCFs);
>       }
>       LOG.info("Peer tableCFs with id= " + id + " is now " + tableCFsStr);
>     } catch (KeeperException e) {
>       throw new ReplicationException("Unable to change tableCFs of the peer with id=" + id, e);
>     }
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)