Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 5 Aug 2015 00:57:04 +0000 (UTC)
From: "Apekshit Sharma (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12615009.1352229607000.372842.1438736224740@Atlassian.JIRA>
In-Reply-To: <JIRA.12615009.1352229607000@Atlassian.JIRA>
References: <JIRA.12615009.1352229607000@Atlassian.JIRA>
 <JIRA.12615009.1352229607462@arcas>
Subject: [jira] [Commented] (HBASE-7105) RS throws NPE on forcing compaction
 from HBase shell on a single bulk imported file.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-7105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654602#comment-14654602 ] 

Apekshit Sharma commented on HBASE-7105:
----------------------------------------

I am here....waiting for some action.
I believe the current patch has correctness issues, but the system as of now can be improved.
How costly is it to open the reader?
If not a lot, then maybe few extra IOs are less trouble then exceptions from UX point of view.

> RS throws NPE on forcing compaction from HBase shell on a single bulk imported file.
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-7105
>                 URL: https://issues.apache.org/jira/browse/HBASE-7105
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Karthik Ranganathan
>            Assignee: Cosmin Lehene
>             Fix For: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.3
>
>         Attachments: 0001-HBASE-7105-RS-throws-NPE-on-forcing-compaction-from-.patch, 0001-HBASE-7105-RS-throws-NPE-on-forcing-compaction-from-.patch
>
>
> In StoreFile, we have:
> private AtomicBoolean majorCompaction = null;
> In StoreFile.open(), we do:
> b = metadataMap.get(MAJOR_COMPACTION_KEY);
> if (b != null) {
>   // init majorCompaction variable
> }
> Because the file was bulk imported, this is never initialized. Any subsequent call to isMajorCompaction() NPE's.
> Fix is to initialize it to false.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)