hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14256) Flush task message may be confusing when region is recovered
Date Sat, 29 Aug 2015 18:11:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721198#comment-14721198
] 

Hadoop QA commented on HBASE-14256:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12751392/HBASE-14256.1.patch
  against master branch at commit 4256128fa248b31c0482bdfc2510011771f84037.
  ATTACHMENT ID: 12751392

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to fail with
Hadoop version 2.4.0.

    Compilation errors resume:
    [ERROR] Error invoking method 'get(java.lang.Integer)' in java.util.ArrayList at META-INF/LICENSE.vm[line
1619, column 22]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process
(default) on project hbase-assembly: Error rendering velocity resource. Error invoking method
'get(java.lang.Integer)' in java.util.ArrayList at META-INF/LICENSE.vm[line 1619, column 22]:
InvocationTargetException: Index: 0, Size: 0 -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following
articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hbase-assembly
    

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15325//console

This message is automatically generated.

> Flush task message may be confusing when region is recovered
> ------------------------------------------------------------
>
>                 Key: HBASE-14256
>                 URL: https://issues.apache.org/jira/browse/HBASE-14256
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0, 1.2.0
>            Reporter: Lars George
>            Assignee: Gabor Liptak
>              Labels: beginner
>         Attachments: HBASE-14256.1.patch
>
>
> In {{HRegion.setRecovering()}} we have this code:
> {code}
>     // force a flush only if region replication is set up for this region. Otherwise
no need.
>       boolean forceFlush = getTableDesc().getRegionReplication() > 1;
>       // force a flush first
>       MonitoredTask status = TaskMonitor.get().createStatus(
>         "Flushing region " + this + " because recovery is finished");
>       try {
>         if (forceFlush) {
>           internalFlushcache(status);
>         }
> {code}
> So we only optionally force flush after a recovery of a region, but the message always
is set to "Flushing...", which might be confusing. We should change the message based on {{forceFlush}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message