hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14249) shaded jar modules create spurious source and test jars with incorrect LICENSE/NOTICE info
Date Wed, 19 Aug 2015 23:03:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703900#comment-14703900
] 

Nick Dimiduk commented on HBASE-14249:
--------------------------------------

Did you build with -Prelease ? That's the only time shaded modules are built.

{noformat}
$ patch -p1 < /tmp/HBASE-14249.patch
$ mvn clean package -DskipTests -Dcheckstyle.skip -Dmaven.javadoc.skip -Prelease
...
[INFO] BUILD SUCCESS
...
$ find hbase-shaded -iname *.jar
hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-1.1.2-tests.jar
hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-1.1.2.jar
hbase-shaded/hbase-shaded-client/target/original-hbase-shaded-client-1.1.2.jar
hbase-shaded/hbase-shaded-server/target/hbase-shaded-server-1.1.2-tests.jar
hbase-shaded/hbase-shaded-server/target/hbase-shaded-server-1.1.2.jar
hbase-shaded/hbase-shaded-server/target/original-hbase-shaded-server-1.1.2.jar
{noformat}

> shaded jar modules create spurious source and test jars with incorrect LICENSE/NOTICE
info
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14249
>                 URL: https://issues.apache.org/jira/browse/HBASE-14249
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.0, 1.2.0, 1.1.2, 1.3.0
>            Reporter: Sean Busbey
>            Assignee: Andrew Purtell
>            Priority: Blocker
>         Attachments: HBASE-14249.patch
>
>
> the shaded jar modules don't need to create a source or test jar (because the jars contain
nothing other than META-INF)
> currently we create 
>  * the test jars are missing LICENSE
>  * source jars have LICENSE/NOTICE files that claim all the bundled works in the normal
jar.
> {code}
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar//META-INF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-server-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar//META-INF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-client-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar//META-INF
> hbase-shaded-client-1.1.2-tests.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar//META-INF
> hbase-shaded-server-1.1.2-tests.jar//META-INF/NOTICE
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message