hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
Date Mon, 24 Aug 2015 12:37:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709186#comment-14709186
] 

Ted Yu commented on HBASE-14229:
--------------------------------

You can run the failed tests locally to see if any test failure is reproducible. 
Last week there was fix for zombie tests. 

Please identify new checkstyle warning and fix it. 

Then you can attach new patch. 

> Flushing canceled by coprocessor still leads to memstoreSize set down
> ---------------------------------------------------------------------
>
>                 Key: HBASE-14229
>                 URL: https://issues.apache.org/jira/browse/HBASE-14229
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1
>            Reporter: sunyerui
>         Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1.patch
>
>
> A Coprocessor override "public InternalScanner preFlush(final Store store, final InternalScanner
scanner)" and return NULL when calling this method, will cancel flush request, leaving snapshot
un-flushed, and no new storefile created. But the HRegion.internalFlushCache still set down
memstoreSize to 0 by totalFlushableSize. 
> If there's no write requests anymore, the memstoreSize will remaining as 0, and no more
flush quests will be processed because of the checking of memstoreSize.get() <=0 at the
beginning of internalFlushCache.
> This issue may not cause data loss, but it will confuse coprocessor users. If we argree
with this, I'll apply a patch later.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message