hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heng Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14227) Fold special cased MOB APIs into existing APIs
Date Tue, 18 Aug 2015 23:47:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702182#comment-14702182
] 

Heng Chen commented on HBASE-14227:
-----------------------------------

{quote}
Rather than a boolean I'd suggest a set of flags... I guess the Java idiom is a List of Enum...
for selecting what "types" of CFs to include in the compaction. 
{quote}

I agree with this approach.  We remove any "mob" method.  And use one {{Enum}} parameter to
select compaction types.

By the way, i found the issue was assigned to me,  but [~jingcheng.du@intel.com] has uploaded
the patch. 
Do i need to submit patch´╝č [~apurtell]

> Fold special cased MOB APIs into existing APIs
> ----------------------------------------------
>
>                 Key: HBASE-14227
>                 URL: https://issues.apache.org/jira/browse/HBASE-14227
>             Project: HBase
>          Issue Type: Task
>          Components: mob
>    Affects Versions: 2.0.0
>            Reporter: Andrew Purtell
>            Assignee: Heng Chen
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14227.patch
>
>
> There are a number of APIs that came in with MOB that are not new actions for HBase,
simply new actions for a MOB implementation:
> - compactMob
> - compactMobs
> - majorCompactMob
> - majorCompactMobs
> - getMobCompactionState
> And in HBaseAdmin:
> - validateMobColumnFamily
> Remove these special cases from the Admin API where possible by folding them into existing
APIs.
> We definitely don't need one method for a singleton and another for collections.
> Ideally we will not have any APIs named *Mob when finished, whether MOBs are in use on
a table or not should be largely an internal detail. Exposing as schema option would be fine,
this conforms to existing practice for other features.
> Marking critical because I think removing the *Mob special cased APIs should be a precondition
for release of this feature either in 2.0 or as a backport.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message