hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-14206) MultiRowRangeFilter returns records whose rowKeys are out of allowed ranges
Date Tue, 11 Aug 2015 16:42:46 GMT

     [ https://issues.apache.org/jira/browse/HBASE-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Yu updated HBASE-14206:
---------------------------
    Fix Version/s: 1.3.0
                   1.1.2
                   1.2.0
                   1.0.2
                   0.98.14
                   2.0.0

> MultiRowRangeFilter returns records whose rowKeys are out of allowed ranges
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-14206
>                 URL: https://issues.apache.org/jira/browse/HBASE-14206
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>         Environment: linux, java7
>            Reporter: Anton Nazaruk
>            Assignee: Anton Nazaruk
>            Priority: Critical
>              Labels: filter
>             Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
>
>         Attachments: 14206-test.patch, 14206-v1.txt
>
>
> I haven't found a way to attach test program to JIRA issue, so put it below :
> {code}
> public class MultiRowRangeFilterTest {
>  
>     byte[] key1Start = new byte[] {-3};
>     byte[] key1End  = new byte[] {-2};
>     byte[] key2Start = new byte[] {5};
>     byte[] key2End  = new byte[] {6};
>     byte[] badKey = new byte[] {-10};
>     @Test
>     public void testRanges() throws IOException {
>         MultiRowRangeFilter filter = new MultiRowRangeFilter(Arrays.asList(
>                 new MultiRowRangeFilter.RowRange(key1Start, true, key1End, false),
>                 new MultiRowRangeFilter.RowRange(key2Start, true, key2End, false)
>         ));
>         filter.filterRowKey(badKey, 0, 1);
>         /*
>         * FAILS -- includes BAD key!
>         * Expected :SEEK_NEXT_USING_HINT
>         * Actual   :INCLUDE
>         * */
>         assertEquals(Filter.ReturnCode.SEEK_NEXT_USING_HINT, filter.filterKeyValue(null));
>     }
> }
> {code}
> It seems to happen on 2.0.0-SNAPSHOT too, but I wasn't able to link one with included
class.
> I have played some time with algorithm, and found that quick fix may be applied to "getNextRangeIndex(byte[]
rowKey)" method (hbase-client:1.1.0) :
> {code}
> if (insertionPosition == 0 && !rangeList.get(insertionPosition).contains(rowKey))
{
>         return ROW_BEFORE_FIRST_RANGE;
> }
> // FIX START
> if(!this.initialized) {
>     this.initialized = true;
> }
> // FIX END
> return insertionPosition;
> {code} 
> Thanks, hope it will help.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message