hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14144) Bloomfilter path to work with Byte buffered cells
Date Tue, 11 Aug 2015 18:08:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682190#comment-14682190
] 

stack commented on HBASE-14144:
-------------------------------

These names are getting a little crazy:

FirstOnRowByteBufferedFakeCell

... and here: FirstOnRowFakeCell

Then we have FirstOnRowColByteBufferedFakeCell but later we write out 'Col' in full: FirstOnRowColumnFakeCell
(perhaps use 'Col' because that is method name)

We have this FakeByteBufferedCell, then this FirstOnRowByteBufferedFakeCell (Why position
of 'Fake' moved?)

What is 'fake' about the Cell?

Otherwise, patch looking good.



> Bloomfilter path to work with Byte buffered cells
> -------------------------------------------------
>
>                 Key: HBASE-14144
>                 URL: https://issues.apache.org/jira/browse/HBASE-14144
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14144.patch, HBASE-14144_1.patch, HBASE-14144_2.patch
>
>
> This JIRA is to check if there will be a need to make the bloom filters to work with
ByteBuffer cells. During POC this path created lot of duplicated code but considering other
refactorings done in this path  may lead to less duplication. This JIRA is a placeholder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message