hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14085) Correct LICENSE and NOTICE files in artifacts
Date Tue, 04 Aug 2015 23:02:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654510#comment-14654510
] 

Hadoop QA commented on HBASE-14085:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12748736/HBASE-14085.3.patch
  against master branch at commit 931e77d4507e1650c452cefadda450e0bf3f0528.
  ATTACHMENT ID: 12748736

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 30 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                <debug-print-included-work-info>${license.debug.print.included}</debug-print-included-work-info>
+                <resourceBundle>${project.groupId}:hbase-resource-bundle:${project.version}</resourceBundle>
+                <supplementalModelArtifact>${project.groupId}:hbase-resource-bundle:${project.version}</supplementalModelArtifact>
+           Build an aggregation of our templated NOTICE file and the NOTICE files in our
dependencies.
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+1.1. “Contributor” means each individual or entity that creates or contributes
to the creation of
+1.2. “Contributor Version” means the combination of the Original Software, prior
Modifications used
+1.5. “Initial Developer” means the individual or entity that first makes Original
Software available
+1.6. “Larger Work” means a work which combines Covered Software or portions thereof
with code not
+1.8. “Licensable” means having the right to grant, to the maximum extent possible,
whether at the

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestMultiParallel
                  org.apache.hadoop.hbase.client.TestScannersFromClientSide
                  org.apache.hadoop.hbase.client.TestFromClientSideNoCodec
                  org.apache.hadoop.hbase.client.TestScannerTimeout
                  org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas
                  org.apache.hadoop.hbase.client.TestTableSnapshotScanner
                  org.apache.hadoop.hbase.client.TestMetaWithReplicas
                  org.apache.hadoop.hbase.namespace.TestNamespaceAuditor
                  org.apache.hadoop.hbase.client.TestHCM
                  org.apache.hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas
                  org.apache.hadoop.hbase.TestIOFencing
                  org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithClusters
                  org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient
                  org.apache.hadoop.hbase.client.TestClientTimeouts
                  org.apache.hadoop.hbase.client.TestMobSnapshotFromClient
                  org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient

     {color:red}-1 core zombie tests{color}.  There are 4 zombie test(s): 

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14974//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14974//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14974//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14974//console

This message is automatically generated.

> Correct LICENSE and NOTICE files in artifacts
> ---------------------------------------------
>
>                 Key: HBASE-14085
>                 URL: https://issues.apache.org/jira/browse/HBASE-14085
>             Project: HBase
>          Issue Type: Task
>          Components: build
>    Affects Versions: 2.0.0, 0.94.28, 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Blocker
>             Fix For: 2.0.0, 0.94.28, 0.98.14, 1.0.2, 1.2.0, 1.1.2
>
>         Attachments: HBASE-14085.1.patch, HBASE-14085.2.patch, HBASE-14085.3.patch
>
>
> +Problems:
> * checked LICENSE/NOTICE on binary
> ** binary artifact LICENSE file has not been updated to include the additional license
terms for contained third party dependencies
> ** binary artifact NOTICE file does not include a copyright line
> ** binary artifact NOTICE file does not appear to propagate appropriate info from the
NOTICE files from bundled dependencies
> * checked NOTICE on source
> ** source artifact NOTICE file does not include a copyright line
> ** source NOTICE file includes notices for third party dependencies not included in the
artifact
> * checked NOTICE files shipped in maven jars
> ** copyright line only says 2015 when it's very likely the contents are under copyright
prior to this year
> * nit: NOTICE file on jars in maven say "HBase - ${module}" rather than "Apache HBase
- ${module}" as required 
> refs:
> http://www.apache.org/dev/licensing-howto.html#bundled-vs-non-bundled
> http://www.apache.org/dev/licensing-howto.html#binary
> http://www.apache.org/dev/licensing-howto.html#simple



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message