hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14085) Correct LICENSE and NOTICE files in artifacts
Date Sat, 01 Aug 2015 10:06:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650248#comment-14650248
] 

Hadoop QA commented on HBASE-14085:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12748295/HBASE-14085.2.patch
  against master branch at commit f504e4b4ed1a8173d1e8420207f608b8572436e2.
  ATTACHMENT ID: 12748295

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 30 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +           Build an aggregation of our templated NOTICE file and the NOTICE files in
our dependencies.
+1.1. Contributor means each individual or entity that creates or contributes to the creation
of Modifications.
+1.2. Contributor Version means the combination of the Original Software, prior Modifications
used by a Contributor (if any), and the Modifications made by that particular Contributor.
+1.3. Covered Software means (a) the Original Software, or (b) Modifications, or (c) the combination
of files containing Original Software with files containing Modifications, in each case including
portions thereof.
+1.5. Initial Developer means the individual or entity that first makes Original Software
available under this License.
+1.6. Larger Work means a work which combines Covered Software or portions thereof with code
not governed by the terms of this License.
+1.8. Licensable means having the right to grant, to the maximum extent possible, whether
at the time of the initial grant or subsequently acquired, any and all of the rights conveyed
herein.
+1.9. Modifications means the Source Code and Executable form of any of the following: A.
Any file that results from an addition to, deletion from or modification of the contents of
a file containing Original Software or previous Modifications; B. Any new file that contains
any part of the Original Software or previous Modification; or C. Any new file that is contributed
or otherwise made available under the terms of this License.
+1.10. Original Software means the Source Code and Executable form of computer software code
that is originally released under this License.
+1.11. Patent Claims means any patent claim(s), now owned or hereafter acquired, including
without limitation, method, process, and apparatus claims, in any patent Licensable by grantor.

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14950//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14950//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14950//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14950//console

This message is automatically generated.

> Correct LICENSE and NOTICE files in artifacts
> ---------------------------------------------
>
>                 Key: HBASE-14085
>                 URL: https://issues.apache.org/jira/browse/HBASE-14085
>             Project: HBase
>          Issue Type: Task
>          Components: build
>    Affects Versions: 2.0.0, 0.94.28, 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Blocker
>             Fix For: 2.0.0, 0.94.28, 0.98.14, 1.0.2, 1.2.0, 1.1.2
>
>         Attachments: HBASE-14085.1.patch, HBASE-14085.2.patch
>
>
> +Problems:
> * checked LICENSE/NOTICE on binary
> ** binary artifact LICENSE file has not been updated to include the additional license
terms for contained third party dependencies
> ** binary artifact NOTICE file does not include a copyright line
> ** binary artifact NOTICE file does not appear to propagate appropriate info from the
NOTICE files from bundled dependencies
> * checked NOTICE on source
> ** source artifact NOTICE file does not include a copyright line
> ** source NOTICE file includes notices for third party dependencies not included in the
artifact
> * checked NOTICE files shipped in maven jars
> ** copyright line only says 2015 when it's very likely the contents are under copyright
prior to this year
> * nit: NOTICE file on jars in maven say "HBase - ${module}" rather than "Apache HBase
- ${module}" as required 
> refs:
> http://www.apache.org/dev/licensing-howto.html#bundled-vs-non-bundled
> http://www.apache.org/dev/licensing-howto.html#binary
> http://www.apache.org/dev/licensing-howto.html#simple



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message