hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13730) Backport HBASE-13576 (Failure in checking one region should not fail the entire HBCK operation) to 0.98
Date Thu, 13 Aug 2015 04:38:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694673#comment-14694673
] 

Lars Hofhansl commented on HBASE-13730:
---------------------------------------

Looks fine to me. Nit:
{code}
+    int numOfSkippedRegions;
     errors.print("Summary:");
     for (TableInfo tInfo : tablesInfo.values()) {
+      numOfSkippedRegions = (skippedRegions.containsKey(tInfo.getName())) ?
+          skippedRegions.get(tInfo.getName()).size() : 0;
+
{code}
Declaring numOfSkippedRegions outside the for loop confused me, since we write to it multiple
times in the loop. Since it's only used inside the loop we just should move the declaration
there to avoid confusion.

Otherwise pretty straightforward... +1


> Backport HBASE-13576 (Failure in checking one region should not fail the entire HBCK
operation) to 0.98
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13730
>                 URL: https://issues.apache.org/jira/browse/HBASE-13730
>             Project: HBase
>          Issue Type: Sub-task
>          Components: hbck
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 0.98.14
>
>         Attachments: HBASE-13730-0.98.patch, HBASE-13730-0.98.patch
>
>
> Backport HBASE-13576 - Failure in checking one region should not fail the entire HBCK
operation - to 0.98



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message