hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12256) Update patch submission guidelines to call out binary file support
Date Mon, 10 Aug 2015 07:03:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679676#comment-14679676
] 

Hudson commented on HBASE-12256:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #6708 (See [https://builds.apache.org/job/HBase-TRUNK/6708/])
HBASE-12256 Update patch submission guidelines to call out binary file support (mstanleyjones:
rev aad7fbe6cd4e5e899fc4badfa7fe0264fe35c443)
* src/main/asciidoc/_chapters/developer.adoc


> Update patch submission guidelines to call out binary file support
> ------------------------------------------------------------------
>
>                 Key: HBASE-12256
>                 URL: https://issues.apache.org/jira/browse/HBASE-12256
>             Project: HBase
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Sean Busbey
>            Assignee: Misty Stanley-Jones
>            Priority: Minor
>              Labels: git
>             Fix For: 2.0.0
>
>         Attachments: HBASE-12256.patch
>
>
> Our guidelines should call out where users need to take special care if they have binary
files in their diff. (binary files here means anything {{file}} detects as "data")
> By default {{git diff}} won't include binary files, instead it'll just say something
like "binary files differ". That'll render the patch useless.
> * Update reasons to favor format-patch to include "can handle binary files changing by
default".
> * Add a note on {{git diff}} (or change the default args) to use {{--binary}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message